MaterialFoundry / MaterialDeck

41 stars 20 forks source link

[FEATURE] Turn off for players. #119

Open Akallabeth13666 opened 4 months ago

Akallabeth13666 commented 4 months ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Hi, each time my players log in they get a pop-up:

image

Which no matter what is selected reloads Foundry for them.

Describe the solution you'd like A clear and concise description of what you want to happen.

I would like to eliminate this pop-up entirely for players especially that it supposed to not be enabled for them:

image

Not sure, perhaps it is a bug then. 🤷

thepting commented 1 month ago

This is happening for me too.

MaterialFoundry commented 1 month ago

The popup reappearing for players is probably not a bug. When a user chooses 'No', this is stored in a client setting which is stored as a cookie by the browser. The popup reappearing can mean one of the following things: -The user is using incognito/private mode in the browser, which means that no cookies are saved -The user has switched browsers -The user cleared their cookies (maybe they've set the browser to automatically clear all cookies after they close the browser) -A bug

I suspect it's one of the first 3, which would mean that many of Foundry's settings will not be saved for them, which is not ideal (not just for Material Deck, but many other modules).

However, I agree that the popup should not show up if the player has no permission to use the module, I'll look into that.