Closed morsapaes closed 2 years ago
@benesch, turns out that upload-artifact@v2
doesn't munch through special characters, and that ecommerce/redpanda
is interpreted as a directory also for the .sh
test file (even escaping the slash). This is a bit gross, but:
The lint check also complained, so I tweaked it to check up to two levels up:
All of this feels kind of 👷♀️🛠️, so let me know if the changes make sense or if there's a more elegant way to go around this.
I guess the question I'd be asking is whether it's worth the trouble to nest the demo directories. If it is, then I think you're stuck doing something like this!
It might be a little clearer if you called the nested demo ecommerce/redpanda
? Then you could declare that the name of the demo is its relative path with all slashes replaced with hyphens. The Python computation of the demo name becomes str(path.parent).replace("/", "-")
and the shell computation of the demo name becomes echo "DEMO=$(echo ${{ matrix.demo }} | tr / -)" >> $GITHUB_ENV
.
No strong feels though!
I guess the question I'd be asking is whether it's worth the trouble to nest the demo directories. If it is, then I think you're stuck doing something like this!
Yeah, I was prematurely worrying about how the repo might grow unruly as we add more demos (via not being able to unsee this vs. this). Thanks for keeping me grounded! :beneschzers:
@ruf-io, there's something weird going on with the item_pageviews
view also in the original repo, so I'll merge this as is to unblock the last mile and get the repo live.
The existing
ecommerce
demo doesn't have a clear separation of concerns for certain components (e.g. deployment of the Debezium connector), which makes it hard to parse for users and causes CI tests to be spotty. This PR shuffles things around to address that. Also fixes #14, though we could still strip it further down by usingdebezium/connect-base
instead ofdebezium/connect
.~Just need to figure out how to add a test for
ecommerce-redpanda
, now that it's embedded in theecommerce
directory.~ One of the materialized views inecommerce
is also spitting out weird results (need to double check if it's pre-existing or related to bumping thematerialized
version somehow, since nothing else changed), but putting it out for review!