MaterializeInc / materialize

The data warehouse for operational workloads.
https://materialize.com
Other
5.65k stars 458 forks source link

test coverage: Ignore "mod tests" sections from (only unit-tested) coverage computation #20594

Open nrainer-materialize opened 11 months ago

nrainer-materialize commented 11 months ago

Feature request

Ignore unit test code from coverage computation, in particular, from "only unit-tested but not higher-level tested".

Example:

@@ -792,13 +781,6 @@ mod tests {
         let s1_state1 = states
             .get::<(), (), u64, i64, _, _>(
                 s1,
!                || {
!                    let did_work = Arc::clone(&did_work);
!                    async move {
!                        did_work.store(true, Ordering::SeqCst);
!                        Ok(new_state(s1))
!                    }
!                },
                 &Diagnostics::for_tests(),
             )

https://buildkite.com/materialize/coverage/builds/182

nrainer-materialize commented 3 weeks ago

@def-, could it be that you have already addressed this?

def- commented 3 weeks ago

Nope, I changed nothing about this.