search

Materials-Consortia / providers-dashboard

A dashboard of known providers
http://www.optimade.org/providers-dashboard
1 stars 3 forks source link

Confusing dashboard links #60

Open CasperWA opened 2 years ago

CasperWA commented 2 years ago

ah, ok, adding 'v1/links' to the url works (but then the link in the dashboard should point to something more informative? or just be the base_url string, not a clickable link...)

Originally posted by @migueldiascosta in https://github.com/Materials-Consortia/providers/issues/74#issuecomment-917538057

This is from a new contributor to the providers repository. I agree that this should be more intuitive and try to point to the latest versioned URL + endpoint where possible.

ml-evs commented 2 years ago

My only issue with changing the links in the dashboard is that some providers may have more informative "landing pages" hosted at those URLs. The main problem occurs when these base URLs 404 without any useful error message, which I think can largely be solved for the static index meta-db's with new redirect/better 404s (see linked issues).

ml-evs commented 2 years ago

I would say this is closed by https://github.com/Materials-Consortia/providers/pull/77, though non-static index meta-databases have the right to serve whatever confusing stuff they want at their base URLs...

CasperWA commented 2 years ago

I would say this is closed by Materials-Consortia/providers#77, though non-static index meta-databases have the right to serve whatever confusing stuff they want at their base URLs...

Yeah, I wouldn't go that far. I'd say this is a separate issue and we (as you also point out here) shouldn't rely on a nice landing page being present at these URLs. I think instead we should consider adding some extra if/else cases for the URLs here? But personally, I'd prefer it to be pointing at the same location. But as an alternative it could try to request the URL, if a 404 or status code >= 400 is returned, it adds /v{major}/info to the URL or something similar?