CDO classes - Githubissues

Materials-Data-Science-and-Informatics / Dislocation-Ontology-Suite

This repository is a home to the Dislocation Ontology Suite (DISOS), an ontology suite comprising several modules describing materials scientific concepts, representations of dislocations, and different simulation models in the dislocation domain.

MIT License

1 stars 1 forks source link

CDO classes #9

Open aazocar opened 1 year ago

aazocar commented 1 year ago

Some adjustments are needed for CDO classes, in order to coherently extend the ontology. Specifically:

The Grain Boundary class is not needed on this level, I propose just one class PlaneDefect, the Grain Boundary class can be extended later on.
Include another class Bulk Defect
Also, LineDefect could be included here as superclass of dislocation? Considering you want to include a disclination class, if not, I guess having LineDefect as equivalent to Dislocation works.

Picture for reference: Screenshot from 2023-03-06 17-36-13

Let me know what you think!

az-ihsan commented 1 year ago

Hi @aazocar, thanks for the review.

That makes sense now and I'll try to incorporate within the next few days. Other than that, having a disclination class is not worth to take as we also discussed with Stefan about this. So we won't include that.

az-ihsan commented 1 year ago

@aazocar would you fix it by yourself making a pull request? or let me fix it?

aazocar commented 1 year ago

Hi @az-ihsan, thanks for checking. I think you can fix it as you see fit. Since you have a better idea how the changes should be made :)