MateriiApps / Gloom

GitHub reimagined with Material You
GNU General Public License v3.0
633 stars 15 forks source link

Allow staring from inside the repositories page #30

Closed ghost closed 1 year ago

ghost commented 1 year ago

I've noticed that inside the repo's page you can't star, you can only see the amount of stars. I don't understand why? Especially since the star and fork are so big. This should be added :)

wingio commented 1 year ago

@oSumAtrIX you can take this

oSumAtrIX commented 1 year ago

@wingio Before I start to work on this issue. I want to discuss implementation designs with you.

OP wants to be able to star from inside the repo page: image

The buttons have no visual implication of being clickable. See GitHub for example: image

How do you imagine this should be implemented?

oSumAtrIX commented 1 year ago

A quick look into M3 specifications also revealed that a segmented button may not be the correct component to use for this UI: image

wingio commented 1 year ago

Those are actually custom implementations of what m3 calls a segmented button, its used in other apps and are usually clickable (see: vendetta manager and pixel settings app pages)

oSumAtrIX commented 1 year ago

How about M3 specs? Do you know if it is compliant? M3 says:

Segmented buttons help people select options, switch views, or sort elements.

Sculas commented 1 year ago

In some cases, apps might deviate from the M3 spec for a better user experience. That could also be the case here?

As for the button not looking clickable, I agree for the most part on desktop, but for mobile this is pretty standard (since it's more of a tap, rather than click). You could maybe add a small white border stroke on hover for desktop only? (if I recall correctly, this app is multiplatform? if not, disregard what I said)

oSumAtrIX commented 1 year ago

I'll likely PR a draft with a basic implementation at first.

wingio commented 1 year ago

as of right now gloom doesn't support desktop, i do plan on doing that later but won't be high priority until the android side is more feature complete

DarkCrypt commented 1 year ago

Future suggestion for stars:

wingio commented 1 year ago

honestly i forgot lists were a thing

DarkCrypt commented 1 year ago

Haha! Maybe I'm the only one that does it.