Closed ghost closed 1 year ago
@oSumAtrIX you can take this
@wingio Before I start to work on this issue. I want to discuss implementation designs with you.
OP wants to be able to star from inside the repo page:
The buttons have no visual implication of being clickable. See GitHub for example:
How do you imagine this should be implemented?
A quick look into M3 specifications also revealed that a segmented button may not be the correct component to use for this UI:
Those are actually custom implementations of what m3 calls a segmented button, its used in other apps and are usually clickable (see: vendetta manager and pixel settings app pages)
How about M3 specs? Do you know if it is compliant? M3 says:
Segmented buttons help people select options, switch views, or sort elements.
In some cases, apps might deviate from the M3 spec for a better user experience. That could also be the case here?
As for the button not looking clickable, I agree for the most part on desktop, but for mobile this is pretty standard (since it's more of a tap, rather than click). You could maybe add a small white border stroke on hover for desktop only? (if I recall correctly, this app is multiplatform? if not, disregard what I said)
I'll likely PR a draft with a basic implementation at first.
as of right now gloom doesn't support desktop, i do plan on doing that later but won't be high priority until the android side is more feature complete
Future suggestion for stars:
honestly i forgot lists were a thing
Haha! Maybe I'm the only one that does it.
I've noticed that inside the repo's page you can't star, you can only see the amount of stars. I don't understand why? Especially since the star and fork are so big. This should be added :)