MateriiApps / OpenCord

An open-source Material You implementation of the Discord Android app
GNU General Public License v3.0
1.24k stars 98 forks source link

feat: crowdin sync #69

Closed rushiiMachine closed 2 years ago

rushiiMachine commented 2 years ago

Uploads/downloads crowdin translations every week or when strings.xml is modified and merges to master.

ghost commented 2 years ago

hey, you can use integration tab on crowdin for that (will update at translation update or when configured)

rushiiMachine commented 2 years ago

you remember how ugly the integration was me when 2000 prs guhhh

X1nto commented 2 years ago

I don't think automatic merging is a good idea

rushiiMachine commented 2 years ago

Hyperion does the same thing as this, and it works really well

ghost commented 2 years ago

you remember how ugly the integration was me when 2000 prs guhhh

mmm right
they squashable tho

ghost commented 2 years ago

and if i remember correctly the integrated bot has translations all on separate branch that is up with master

X1nto commented 2 years ago

Hyperion does the same thing as this, and it works really well

Now imagine someone fucks up string templates in crowdin, bot pushes it and it's merged so now build is fucked up

wingio commented 2 years ago

i mean crowdin requires reviews on each translation

X1nto commented 2 years ago

meh fair then

rushiiMachine commented 2 years ago

The only thing I'm not sure about is if it can push to master since it has branch protection trol

X1nto commented 2 years ago

I'll off the protection