search

MathCancer / PhysiCell

PhysiCell: Scientist end users should use latest release! Developers please fork the development branch and submit PRs to the dev branch. Thanks!
http://PhysiCell.org
134 stars 91 forks source link

PhysiCell_settings-backup.xml concept is broken #259

Open elmbeech opened 3 months ago

elmbeech commented 3 months ago

the Makefile reset function relies on a PhysiCell_settings-backup.xml file. the problem is that not all sample project generate aPhysiCell_settings-backup.xml.
the bigger problem is that Makefile load function not generate at PhysiCell_settings-backup.xml.

as far as I can see, the PhysiCell_settings-backup.xml is only used by the reset function.

in my opinion, it would be wiser to have similar to the sample_projects/Makefile-default a sample_projects/PhysiCell_settings.xml-default and use this for the reset function.

elmbeech commented 3 months ago

The basic problem is now resolved in this pull request #244. The Makefile reset function uses now sample_projects/PhysiCell_settings.xml-default to restore the initial condition.

I did not look into why some sample projects do make a PhysiCell_settings-backup.xml and some don't. In my opinion, backups should be there just for safety. No code should rely on backups.