Check MacOS version - Githubissues

MathEXLab / PySPOD

A Python package for spectral proper orthogonal decomposition (SPOD).

https://mathexlab.github.io/PySPOD/

MIT License

97 stars 29 forks source link

Check MacOS version #49

Closed mrogowski closed 2 months ago

mrogowski commented 2 months ago

macos-latest has been upgraded to MacOS 14 running on M1. It consistently fails the orthogonality check: https://github.com/MathEXLab/PySPOD/actions/runs/8864649865/job/24485136262#step:12:127

Fixes:

Using arm64 architecture for setup-python on macos.
Excluding macos with Python 3.8 - pip dependencies issue?
Increasing the check_orthogonality tolerance to 2e-6 (the actual error was ~1.8e-6 on arm64).

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.72%. Comparing base (28ffd6b) to head (9e901cb).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #49 +/- ## ======================================= Coverage 76.72% 76.72% ======================================= Files 16 16 Lines 3532 3532 Branches 554 554 ======================================= Hits 2710 2710 Misses 664 664 Partials 158 158 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.