search

MathGaron / pytorch_toolbox

Boiler plate code for pytorch. Train/Validation loops, visualization etc. For research.
MIT License
10 stars 3 forks source link

Variable name `isvalid` confused #21

Closed jacenfox closed 6 years ago

jacenfox commented 7 years ago

https://github.com/MathGaron/pytorch_toolbox/blob/68055faf7017b3a3e8cc96b9f87d99220f28f562/pytorch_toolbox/loop_callback_base.py#L7

Change the variable name to istest, isvalidation or istraining should be better.

MathGaron commented 7 years ago

indeed, just pick isvalidation or istraining :) (I think that istraining is better personally)

jacenfox commented 7 years ago

I prefer istraining too. In this case, we will also need to change the if statements in the callback objects. (from isvalid to istraining)

MathGaron commented 7 years ago

sure you can make a branch and I will merge it :)

jacenfox commented 6 years ago

Thanks to Mathieu.