MathHubInfo / Legacy-localmh

DEPRECATED - A cross-repository administration tool for the local authoring in MathHub.info
1 stars 0 forks source link

lmh setup --update seems to always load MMT #284

Closed kohlhase closed 8 years ago

kohlhase commented 8 years ago

I suspect that it does not check if it needs to load.

cmaeder commented 8 years ago

I'm afraid wget cannot check if it needs to download https://github.com/KWARC/MMT/raw/gh-pages/deploy/mmt.jar again because the directory is not browsable.

cmaeder commented 8 years ago

In https://github.com/KWARC/localmh/issues/279 wget -c -N is recommended, but these options don't avoid reloading (only resume partial downloads) and @tkw1536 omitted them for now

./lmh/lib/packs/setups/MMT.py:        proc = subprocess.Popen([wget_executable, self.mmt_jar_source, "-O", mmt_jar_path], stderr=sys.stderr, stdout=sys.stdout)
cmaeder commented 8 years ago

We need to test if this really changes something.

cmaeder commented 8 years ago

I get

Verbindungsaufbau zu raw.githubusercontent.com (raw.githubusercontent.com)|185.31.17.133|:443... verbunden.
HTTP-Anforderung gesendet, warte auf Antwort... 200 OK

    Download der Datei schon vollständig; kein Download notwendig.

this looks good. (I hope it will pick up changes made to gh-pages.)

cmaeder commented 8 years ago

I also get

WARNUNG: Zeitstempel funktionieren nicht in Kombination mit der Option
»-O«.  Genauere Erläuterungen finden Sie im Handbuch.

so maybe the option -N should be omitted.

kohlhase commented 8 years ago

in my last update, it did not load MMT, but took a long time to determine that it was up to date. This seems OK from my side.

cmaeder commented 8 years ago

These options must be removed again. -N is ignored and -c will fail (or corrupt the file) when mmt.jar is updated.

cmaeder commented 8 years ago

Usually wget preserves/takes the date of the file from the server, but github does not return a Last-Modified header. Therefore this issue won't fix.