Closed patrickomatic closed 8 months ago
I was working on something else and noticed the code here has these two swapped. Reading the docs it seems like xfId should map to format_id and builtinId to builtin_id. I also found a second place where the vertical/horizontal attrs are flipped
xfId
format_id
builtinId
builtin_id
@patrickomatic I had not noticed this. Thanks for the PR.
I was working on something else and noticed the code here has these two swapped. Reading the docs it seems like
xfId
should map toformat_id
andbuiltinId
tobuiltin_id
. I also found a second place where the vertical/horizontal attrs are flipped