search

MathNya / umya-spreadsheet

A pure rust library for reading and writing spreadsheet files
MIT License
239 stars 41 forks source link

Use Clippy #139

Closed patrickomatic closed 8 months ago

patrickomatic commented 8 months ago

Hi, apologies for the extremely large change but I thought that it would be great for this library to use clippy to enforce common coding standards and best practices. There are a lot of changes here but fortunately they are all pretty much the same changes repeated all over the place. And none of them affect functionality - they are all just style changes

I created two macros here: https://github.com/MathNya/umya-spreadsheet/compare/master...patrickomatic:umya-spreadsheet:use-clippy?expand=1#diff-4494fe6dbf95718223777235622fbbb23e342a166b0b558f80d3904007a98cbdR6 which allowed me to combine a lot of repetitive code and at the same time fix warnings by clippy

To make sure any future problems are caught I set up a github actions workflow to: 1.) build the PR 2.) run clippy 3.) run rustfmt and 4.) run tests

MathNya commented 8 months ago

@patrickomatic Thanks for the great PR. We will merge them.