search

MathNya / umya-spreadsheet

A pure rust library for reading and writing spreadsheet files
MIT License
239 stars 41 forks source link

Fix for sheet name containing xml escape sequence #145

Closed agentjill closed 7 months ago

agentjill commented 7 months ago

As reported in issue #143 , the following is my approach towards solving this. Kindly look into this

agentjill commented 7 months ago

Another approach is to use worksheet.set_name(convert_character_reference(&name_value)); instead of explicitly calling quick-xml again.

MathNya commented 7 months ago

@agentjill Thank you for your consideration. I think this modification is smart and good. Please release Draft and we will merge it.

https://github.com/MathNya/umya-spreadsheet/pull/145/files#diff-f0f4f74f345f6f1fa8641d024663826eefc687ba2f3bea48d3415e455f366adfR44

agentjill commented 7 months ago

@MathNya thanks for the consideration.

MathNya commented 7 months ago

@agentjill We will merge them.