MathNya / umya-spreadsheet

A pure rust library for reading and writing spreadsheet files
MIT License
239 stars 41 forks source link

added additional attribute "hidden" #149

Closed agentjill closed 7 months ago

agentjill commented 7 months ago

In some sheets the some cells are set to "hidden" as part of protection to make their internal value (mostly formula) not accessible. The support for the same is added. Kindly look for change in the function pub(crate) fn get_hash_code(&self) -> String {...} for required change which I feel is necessary and not sure as to how to go about it

MathNya commented 7 months ago

@agentjill Thanks for the PR. Please implement get_hash_code() like this.

    pub(crate) fn get_hash_code(&self) -> String {
        format!(
            "{:x}",
            md5::Md5::digest(format!("{}{}", &self.locked.get_hash_string(), &self.hidden.get_hash_string()))
        )
    }
agentjill commented 7 months ago

@MathNya as requested the get_hash_code(&self) is also added and kindly approve PR if all is OK

MathNya commented 7 months ago

@agentjill We have confirmed that there are no problems with the modifications. We will merge them.