search

MathNya / umya-spreadsheet

A pure rust library for reading and writing spreadsheet files
MIT License
238 stars 41 forks source link

moved `const` strings into separate variables for readability. #161

Closed agentjill closed 6 months ago

agentjill commented 6 months ago

@MathNya when reading the source, I felt there are excess number of magic strings floating around. Therefore, I moved them into corresponding variables in naming convention as of "openpyxl". If you approve this, I will be planning to move them into a separate file.

agentjill commented 6 months ago

@MathNya kindly suggest necessary changes

MathNya commented 6 months ago

@agentjill Thank you for your suggestion. const looks better if we put them in one file. It looks like the following.

[src\helper\const.rs]. pub const VML_NS: &str = "http://schemas.openxmlformats.org/officeDocument/2006/relationships/vmlDrawing";

By doing so, it could be used for writer\xlsx\content_types.rs etc.

Thank you for your confirmation.

agentjill commented 6 months ago

@MathNya I have done refactoring as much as possible. I agree there is still pending refactor in some few places. I feel this point is good enough for your review to merge. Kindly look and suggest necessary changes.

agentjill commented 6 months ago

@MathNya, the work is mostly done apart one or two instances of refactoring. Kindly merge this PR so that additional work can be done on my part regarding milestones of this repo.

MathNya commented 6 months ago

@agentjill I have verified that the modifications are correct and will merge them in.

Thank you very much for your help this year. Have a happy new year!