Changing Reference of Option to Optional Reference

MathNya / umya-spreadsheet

A pure rust library for reading and writing spreadsheet files

MIT License

238 stars 41 forks source link

Closed agentjill closed 5 months ago

agentjill commented 5 months ago

Alert this is a breaking change

The &Option<T> in the library has been changed to Option<&T> similarly for mutable case for better memory management and general uniformity in the code base.
Changed the unnecessary match statements to if let syntax for better readability.
Removed unnecessary let _ = and making code more idiomatic.
Also changed unnecessary if let Some(_) pattern to is_some() function
Also sprinkled in some general improvements.

agentjill commented 5 months ago

@MathNya if you want to merge this PR kindly squash the commits into a single commit, for better git history.

MathNya commented 5 months ago

@agentjill Thanks again for the tremendous corrections. We will merge them.