search

MathNya / umya-spreadsheet

A pure rust library for reading and writing spreadsheet files
MIT License
238 stars 41 forks source link

Changing `CellRawValue` Variant to be more meaningful #202

Closed agentjill closed 2 days ago

agentjill commented 3 days ago

@MathNya, The Variant of Enum CellRawValue is given as Null. I find it to be confusing to the user. Therefore, I changed the name of the default item of the CellRawValue to be Empty to be more meaningful.

In src/structs/cell_value.rs & src/structs/cell.rs the function set_value() if given text "NULL" would store nothing into a cell, which can also be achieved when passed "". Therefore, I feel this should be rationalised.

Note: This would be a breaking change

MathNya commented 2 days ago

@agentjill Thank you very much. I don't see any problem and will merge it.