MathNya / umya-spreadsheet

A pure rust library for reading and writing spreadsheet files
MIT License
276 stars 44 forks source link

feature request: add supoprt AsRef<Path> argument for reader/writers #70

Closed usagi closed 2 years ago

usagi commented 2 years ago

Current reader/writer argument spec ( path: &str ):

umya_spreadsheet::reader::read( std::path::Path::new( "./some.xlsx" ) ) // 🆗
umya_spreadsheet::reader::read( "./some.xlsx" ) // 🆖

Add support AsRef<Path> argument:

umya_spreadsheet::reader::read( std::path::Path::new( "./some.xlsx" ) ) // 🆗
umya_spreadsheet::reader::read( "./some.xlsx" ) // 🆗
umya_spreadsheet::reader::read( "./some.xlsx".to_string() ) // 🆗
umya_spreadsheet::reader::read( /* Path, PathBuf, &str, String, and etc. */ ) // 🆗

Motivations

  1. I want it to be easy. 🤣
  2. From the internal implementation point of view, AsRef seems fine. It also improves usability for library users. 👩‍💻