MathRobin / Never-Consent

Never consent to any GDPR consent management platform
MIT License
255 stars 16 forks source link

Sirdata updated again #43

Closed Shadok closed 4 years ago

Shadok commented 4 years ago

sirData updated their code again, but this time, all the button have the same class, and we need to rely on the children span to identify the right button to click.

So it's not a simple class name updating. Maybe if you add a parent bool parameter to the elClick function, so the given selector parameter would be used to locate the first button parent element ?

MathRobin commented 4 years ago

Hell, will see when i have time. Don't hesitate to make a PR if you want. Many thanks for the bug report !

Shadok commented 4 years ago

Pull request #45 created :)

MathRobin commented 4 years ago

Merged, but sadly, they already updated it again...

MathRobin commented 4 years ago

Again: many thanks !