search

MathRobin / Never-Consent

Never consent to any GDPR consent management platform
MIT License
255 stars 16 forks source link

Updated SirData new behaviour #44

Closed Shadok closed 4 years ago

Shadok commented 4 years ago

Allow targeting parent elements to click to match SirData new behaviour, with updated classes. Related to issue #43.

I didn't found a way to test this since Firefox doesn't allow unsigned extensions anymore.

elClick function was updated to allow a third parameter, to specify if we should target the parent element of the one matching the given selector(s).

MathRobin commented 4 years ago

Will have a look soon. Many thanks for this proposal !

FYI: you can try unsigned extension in developer mode on Chrome. The manifest.json is common for both browsers

Shadok commented 4 years ago

Thanks for the tip, my code seems to work well :)

Shadok commented 4 years ago

Cancelling this PR, i forgot to create a branch in my repo, making it a mess. I'll start over :)