MathWebSearch / mws

MathWebSearch Implementation
https://search.mathweb.org/
GNU General Public License v3.0
46 stars 12 forks source link

MWS should accept harvest files with .xml extension #67

Closed physikerwelt closed 10 years ago

physikerwelt commented 10 years ago

In earlier versions MWS supported the xml files with the extension .xml Today it only supports files with the extension .harvest I wonder if there is a special reason for this change Are the .harvest files no valid xml files? I would be happy if the old behaviour that xml files are accepted as harvest would be reproduced.

Raduh commented 10 years ago

Is there any reason to accept .xml instead of just .harvest? .harvest files are generated by the harvester and they abide a certain format. .xml files that do not have that format cannot be indexed by MWS.

physikerwelt commented 10 years ago

The practical reason is that this prevents my harvest files https://github.com/wikimedia/mediawiki-extensions-MathSearch/blob/master/maintenance/CreateMathIndex.php created via, from being read. In the format description you are referring to there is hint that the file extension must be .harvest At least I think it would be a good idea to announce such API breaking changes on the mailing-list.

Raduh commented 10 years ago

Sorry, I misunderstood your question. The format itself is backwards compatible. It is just the extension that defaults to .harvest If you need to index .xml files that respect the harvest format, you can use --harvest-file-extension xml or -e xml as a flag to mwsd.

physikerwelt commented 10 years ago

thx