search

MathematicalMedicine / diver-issues

Semipublic tracking of issues for the DIVER front end
0 stars 0 forks source link

NCONTAINS constraint type is not working properly #241

Closed WValenti closed 5 months ago

WValenti commented 5 months ago

Screenshot 2024-05-28 at 2 40 50 PM

Viqsi commented 5 months ago

We've determined it's because the regex provided is bad - RLIKE '[^4]' means has at least one value that is not 4.

A proper fix would be use of NOT RLIKE, but that would take Bonus Effort(tm) because of how constraint types are defined in diverweb (presence of any regex implies use of RLIKE; NOT RLIKE would need something different - oh, and that'd be a new Preview/NewCohort proc pair).

Viqsi commented 5 months ago

Turns out that the constraints handling in diverweb is actually fairly isolated because we just don't use it in all that many places. So this is less effort than I'd anticipated. Giving it a shot now.

Viqsi commented 5 months ago

This was being done for a CUSTOM VARIABLE, not a cohort. That is not fixed.