First, a UI preference -- I think that if [Compare Variables] is shown as a full-text button, than "edit variable fields" should be the same, because otherwise it almost looks like clicking on the pencil is the thing to do to compare variables.
Second, there may be a confusing retention of values (or not) -- When I initially edit variable fields, then click [Submit for Review], everything works like I'd expect, so no problems. But if I go back in the same session to edit that variable again (like maybe I forgot something), I have all my earlier new values in the fields so it seems like DIVER retrieved my edit and is allowing me to change it. If you then hit [CANCEL] instead of [Submit for Review], it clears the fields (but you stay on the edit page, which itself seems wrong). And then you go to edit it a third time, and your earlier new values are not in the fields, so I think that they're not really being retrieved like I intially thought, but instead just hanging about in REACT somewhere.
First, a UI preference -- I think that if [Compare Variables] is shown as a full-text button, than "edit variable fields" should be the same, because otherwise it almost looks like clicking on the pencil is the thing to do to compare variables.
Second, there may be a confusing retention of values (or not) -- When I initially edit variable fields, then click [Submit for Review], everything works like I'd expect, so no problems. But if I go back in the same session to edit that variable again (like maybe I forgot something), I have all my earlier new values in the fields so it seems like DIVER retrieved my edit and is allowing me to change it. If you then hit [CANCEL] instead of [Submit for Review], it clears the fields (but you stay on the edit page, which itself seems wrong). And then you go to edit it a third time, and your earlier new values are not in the fields, so I think that they're not really being retrieved like I intially thought, but instead just hanging about in REACT somewhere.