search

MathematicalMedicine / diver-issues

Semipublic tracking of issues for the DIVER front end
0 stars 0 forks source link

Creating new subsets seems to work, but no individuals are inserted into the resultSetInds table #9

Closed WValenti closed 2 years ago

WValenti commented 2 years ago

This has been a result of several problems; the first being inconsistency in migrating between versions of ind_ids (old, dist, new, re-deidentified) such that the cleaned kibble table references were to old-format re-deidentified ind_ids while the rest of the tables were to new-format re-deidentified ind_ids. The second problem was a difference in philosophy between Jo and I on how to avoid redundancy with the "- ALL individuals -" resultSetId. It has been resolved by adding a resultSetRemaps which remaps personal "- ALL individuals -" to whatever is appropriate depending upon level of collection access. For all users except testSZOnly, it is to resultSetId 1, which really is all. This solves our insert problem AND prepares for the future, so hah!

WValenti commented 2 years ago

This was only done in the webapp API ATM, so it is vaguely untestable. Going to insert into the prototype code as well so we can verify functionality.

WValenti commented 2 years ago

Done for subsetting, and works OK. Not going to attempt for set operations, as I'd originally avoided set operations with "- ALL individuals -" and therefore didn't implement rigorous filtering (just removed it from the list of possible operands). Implementing remapping here now would be a chunk of work and fraught with possible problems, so I'm simply reverting to the aforementioned removal. Might as well only debug the process once, and do so in Jo's reimplementation w/the API.