ESLint + fix text color property having no effect + extract css

MatheusrdSantos / vue-quick-chat

A simple chat component created with Vue.js

MIT License

128 stars 45 forks source link

ESLint + fix text color property having no effect + extract css #13

Closed Tofandel closed 4 years ago

Tofandel commented 4 years ago

Auto linting + formatting
Fix the text color setting having no effect
Replace scoping css and js bundling by normal css import to avoid heavy dom (see readme.md)

MatheusrdSantos commented 4 years ago

Hi, @Tofandel I found a problem when testing your pull request. I got this message when run yarn serve

Furthermore, when I installed less-loader another error still appearing.

Tofandel commented 4 years ago

I'll fix this tomorrow but I think you're missing less as well npm install -D less-loader less Forgot that I had less installed globally on npm so I forgot to check that it was on the package

Tofandel commented 4 years ago

It's fixed, I also added a new functionality for loading messages when you reach the top of the scroll (documented in readme and with a test in the App.vue) Would be cool to add some unit tests now

MatheusrdSantos commented 4 years ago

I really liked the upload functionality. That is a good idea to add some unit test. I'll think about it in future implementations. Thank you again!