Last input of movie is duplicated after movie ends

GoogleCodeExporter commented 9 years ago

What steps will reproduce the problem?
1. Play both attached movies (GB Tetris)

What is the expected output? What do you see instead?
Both movies are identical, except that one has an additional frame (with no 
pressed buttons) at the end. They should produce the same result, but they 
don't.

What version of the product are you using? On what operating system?
Tested on BizHawk 1.5.3, 1.8 and 1.9.1

Please provide any additional information below.
Looking at the trace log reveals that in the shorter movie, the last input 
frame (pressing down) in frame 1190 is also illegitimately applied in frame 
1191, desyncing the two movies. I haven't looked into the code too much, it may 
or may not be Gambatte-specific.

Original issue reported on code.google.com by MrWin...@gmail.com on 5 Jan 2015 at 4:35

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by adeli...@tasvideos.org on 5 Jan 2015 at 4:56

Changed state: Accepted
Added labels: Priority-High

GoogleCodeExporter commented 9 years ago

Original comment by adeli...@tasvideos.org on 5 Jan 2015 at 4:56

GoogleCodeExporter commented 9 years ago

FIxed, in revision 8760.  Both movies will complete the game as intended, no 
duplicate frame of input occurs.

Original comment by adeli...@tasvideos.org on 10 Jan 2015 at 3:23

Changed state: Fixed

MathewWi / bizhawk

Last input of movie is duplicated after movie ends #358