search

MathewWi / glidehqplusglitch64

Automatically exported from code.google.com/p/glidehqplusglitch64
0 stars 0 forks source link

PUZZLE LEAGUE N64 - toggling between "buff_clear" #152

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The current default setting of "buff_clear=0" is good for showing the 
transition effects(very nice).
But playing the puzzle in the stadium will have flickering glitches on the top 
border which is disturbing while playing.

I would suggest adding the following check: 
(settings.buff_clear || settings.hacks&hack_PPL && settings.ucode == 6)
- after "if (_debugger.capture)" in Main.cpp

This will clear buffer which will fix the top border glitches in the stadium 
and still have the transition effects without manual toggling. So far, it works 
well for me. For your consideration.

Original issue reported on code.google.com by pokefan0...@gmail.com on 19 Sep 2010 at 8:44

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
No longer required.
You can close as invalid.

Original comment by pokefan0...@gmail.com on 24 Nov 2010 at 10:47

GoogleCodeExporter commented 9 years ago 
Gonetz,
If you do not want to accept this issue, please close it

Original comment by pokefan0...@gmail.com on 4 Jun 2011 at 6:55

GoogleCodeExporter commented 9 years ago 
Your hack works. Added. Thanks!

Original comment by gon...@ngs.ru on 22 Jun 2011 at 6:11

GoogleCodeExporter commented 9 years ago 
I check out your fix on my compilation and it causes graphical glitches in 
Mimic Mansion & Stadium battle.

Why is the following missing from main.cpp of Glide64?
 if (ini->Read(_T("PPL"), -1) == 1) settings.hacks |= hack_PPL;

Original comment by pokefan0...@gmail.com on 28 Jul 2011 at 11:53

Attachments:

GoogleCodeExporter commented 9 years ago 
I think the ini default setting for PPL is 0 and the PPL setting for Pokemon 
Puzzle League is 1.  
Either the default for PPL is set to 1 or we need to read the ini for the game 
correct PPL setting.

Original comment by pokefan0...@gmail.com on 29 Jul 2011 at 1:11

GoogleCodeExporter commented 9 years ago 
I removed PPL setting from the ini. The Pokemon Puzzle League hack is enabled 
as:

  else if (strstr(name, (const char *)"PUZZLE LEAGUE"))
    settings.hacks |= hack_PPL;

Try to build trunk sources. Mimic Mansion works without glitches for me.

Original comment by gon...@ngs.ru on 20 Aug 2011 at 6:54

GoogleCodeExporter commented 9 years ago 
I remove PPL from your ini and compile from your trunk and it except the 
following when comparing screenshot taken from yours against my fix on 
MyGlide64.

image1 is from latest Glide64 WIP "Stadium Battle", you will notice there is 
still the corrupted thin line across the puzzle window which does not appear on 
mine(image2).
Also, the bottom of image1 is truncated, compare to my image2.

Original comment by pokefan0...@gmail.com on 20 Aug 2011 at 7:47

Attachments:

GoogleCodeExporter commented 9 years ago 
You will notice that image1 has a very thick black strip on top which means 
actual display has been push down off the screen which is why the bottom 
portion is truncated.

Original comment by pokefan0...@gmail.com on 20 Aug 2011 at 7:51

GoogleCodeExporter commented 9 years ago 
Bottom truncation happens in Mimic Mansion as well when I check against latest 
Glide64 WIP.

Original comment by pokefan0...@gmail.com on 20 Aug 2011 at 8:00

GoogleCodeExporter commented 9 years ago 
Gonetz,
I notice the following hack for PPL is still in your trunk whereas I have 
already removed from MyGlide64.  It may make a different if you remove it too.

rdp.cpp@460
    height = rdp.ci_lower_bound;
/*    if (settings.hacks&hack_PPL)
      height -= rdp.ci_upper_bound;*/ // remove PPL hack

Original comment by pokefan0...@gmail.com on 20 Aug 2011 at 10:45

GoogleCodeExporter commented 9 years ago 
Screen shot from the current trunk

Original comment by gon...@ngs.ru on 22 Aug 2011 at 6:25

Attachments:

GoogleCodeExporter commented 9 years ago 
I believe your screenshot is taken using 4:3 which is correct.
With 16:9, the screenshot actually got truncated at the bottom though it is 
correct on display (screenshot bug - reported previously - I fixed it in 
MyGlide64).
But there is still that thin line cutting across the puzzle window for 16:9 for 
trunk as well - try it.

For MyGlide64, I don't have issue for screenshot or the line bug with 4:3 or 
16:9.

Original comment by pokefan0...@gmail.com on 22 Aug 2011 at 8:32

GoogleCodeExporter commented 9 years ago 
I took new screenshot for mimic mansion and stadium for r248 and 4:3 ratio is 
working correctly - image2 & 4.
With 16:9, the bottom portion is still truncated for the screenshot and there 
is a thin moving up and down in mimic mansion while the thin line cutting 
across puzzle window is no longer there.

Original comment by pokefan0...@gmail.com on 1 Sep 2011 at 4:27

Attachments: