Aspect ratio error for some images in fullscreen 'Borders' mode.

MathewWi / nulldc

Automatically exported from code.google.com/p/nulldc

0 stars 1 forks source link

Aspect ratio error for some images in fullscreen 'Borders' mode. #295

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Usually the Aspect Ratio -> Borders option in nullDC keeps the correct DC 4:3 
ratio in fullscreen, with black borders at either side.

Sometimes though some images are stretched to fit the whole screen, regardless 
of this setting.

Examples are:
The Sega copyright logo seen when loading any game.
Loading screens in Dinosaur, Rayman 2, Test Drive V-Rally and others.

Tested on r78, GDI images.

Original issue reported on code.google.com by matbur...@gmail.com on 14 Oct 2010 at 1:50

GoogleCodeExporter commented 9 years ago

[deleted comment]

GoogleCodeExporter commented 9 years ago

[deleted comment]

GoogleCodeExporter commented 9 years ago

i think this is what's supposed to be

borders just "hide" what is being rendered behind them, but the renderer still 
calculates everything as if there were no borders

wouldn't it be better to have borders as real screen limiters?

Original comment by neckil...@gmail.com on 15 Oct 2010 at 4:41

GoogleCodeExporter commented 9 years ago

No, this only happens on fully 2d images, such as loading screens. They get 
stretched to the wrong ratio instead of being 4:3.

Original comment by matbur...@gmail.com on 15 Oct 2010 at 1:18

GoogleCodeExporter commented 9 years ago

yes, 2d images are relative to the screen size, borders just mask the extra 
screen rendered

Original comment by neckil...@gmail.com on 15 Oct 2010 at 10:49

GoogleCodeExporter commented 9 years ago

I'd say the other way around - 2d images are relative to the ratio they're 
originally drawn in, if they're stretched then that's incorrect behaviour.

Here's two pics as an example of this issue. The first is Dinosaur's title 
screen, a 2d image which is correctly displayed as 4:3 with borders (as 
'Borders' is the option I've chosen). The second is the loading screen for the 
demo, a 2d image which is stretched to the 16:9 ratio of my screen, even though 
I requested 'Borders' mode.
The image looks stretched also - it should be in 4:3.

Original comment by matbur...@gmail.com on 16 Oct 2010 at 2:40

Attachments:

[Dinosaur 1.jpg](https://storage.googleapis.com/google-code-attachments/nulldc/issue-295/comment-6/Dinosaur 1.jpg)
[Dinosaur 2.jpg](https://storage.googleapis.com/google-code-attachments/nulldc/issue-295/comment-6/Dinosaur 2.jpg)

GoogleCodeExporter commented 9 years ago

Frame buffer rendering currently doesn't take into account the rendering mode, 
thats the problem. Known problem (well, more like a limitation of my code)

Original comment by drkIIRaziel on 16 Oct 2010 at 10:55

Changed state: Accepted
Added labels: Type-Defect
Removed labels: Type-Enhancement

GoogleCodeExporter commented 9 years ago

This issue was closed by revision r82.

Original comment by drkIIRaziel on 21 Oct 2010 at 11:00

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

verify fix pls

Original comment by drkIIRaziel on 21 Oct 2010 at 11:01

GoogleCodeExporter commented 9 years ago

Verified, thanks for fixing this issue.

Original comment by matbur...@gmail.com on 27 Oct 2010 at 5:21