search

MathiasGruber / TheNinjaRPG

Source code for TheNinja-RPG
https://www.theninja-rpg.com
60 stars 20 forks source link

Fix Ramen Shop discount, Show only players inside village at hospital #176

Closed WizzzzardMedia closed 2 hours ago

WizzzzardMedia commented 1 week ago

Pull Request

Fix: Right now the ramen discount doesn't get applied. It only shows the discounted price in the UI, but the full, undiscounted price is deducted when you buy the ramen.

Add: Also code always applied the ramen discount of the players home village, it makes more sense if a player visits an allied village that the discount of that village is used instead

Fix: Right now all players in the sector are shown at the hospital for meds to heal them, but only players inside the village can be healed.

Fix: calcIsInVillage missing one location (4, 1)

385248794-4317eb11-eb14-4142-89b5-4f8ab39ffc39 ^Should cost 44.5 ryo (50% discount), but 89 is charged

a491e2ca19760d7e1fb34dba6bf8cc3d ^Can't heal user outside the village, but user is still listed...

image ^4,1 still inside village

License

By making this pull request, I confirm that I have the right to waive copyright and related rights to my contribution, and agree that all copyright and related rights in my contributions are waived, and I acknowledge that the Studie-Tech ApS organization has the copyright to use and modify my contribution for perpetuity.

vercel[bot] commented 1 week ago

@WizzzzardMedia is attempting to deploy a commit to the TheNinja-RPG Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 2 hours ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tnr ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 4:12pm
MathiasGruber commented 2 hours ago

So sorry for being slow on this, I'm merging, thanks for the contribution! I will add 50 reputation points to your account!