search

Mathics3 / mathics-scanner

Tokenizer, and character tables, operator precedence, and conversion routines for the Wolfram Language.
GNU General Public License v3.0
17 stars 3 forks source link

Change more symbols to letter-like #35

Closed TiagoCavalcante closed 2 years ago

mmatera commented 3 years ago

LGTM Thanks for the work!

TiagoCavalcante commented 3 years ago

I converted it to draft again because there are more symbols that should be letter-like, but doing it fail the tests.
mathics-core tests need to be updated, some of them are testing against the ASCII version of the symbol, which sometimes is only available in Unicode. (e.g.: E vs ⅇ)

rocky commented 3 years ago

I converted it to draft again because there are more symbols that should be letter-like, but doing it fail the tests. mathics-core tests need to be updated, some of them are testing against the ASCII version of the symbol, which sometimes is only available in Unicode. (e.g.: E vs ⅇ)

Yes, I think what is needed in mathics-core is to check if the result is unicode and compare against a supplied unicode expected result when that is passed (and the result is unicode).

We sadly also need to be able to support situations where unicode isn't available which happens a lot on MS Windows.

TiagoCavalcante commented 3 years ago

I think it is good now, I didn't changed to ASCII vs Unicode thing, but 147 more symbols are letter-like now.