versioning - Githubissues

IzzySoft commented 2 months ago

The APK at release 0.1 identifies as

package: name='com.virtual_pen' versionCode='1' versionName='1.0'

i.e. its versionName does not match. Might be a bit confusing with later updates (remember to also increase versionCode with each of those).

Further, a small note:

SigningBlock blobs:
-------------------
0x504b4453 (DEPENDENCY_INFO_BLOCK; GOOGLE)

This can be easily avoided:

android {
    dependenciesInfo {
        // Disables dependency metadata when building APKs.
        includeInApk = false
        // Disables dependency metadata when building Android App Bundles.
        includeInBundle = false
    }
}

For some background: that BLOB is supposed to be just a binary representation of your app's dependency tree. But as it's encrypted with a public key belonging to Google, only Google can read it – and nobody else can even verify what it really contains.

Thanks in advance for checking & fixing :smiley:

Mathieu-Beliveau commented 2 months ago

Should be done. Thank for the cues, this is my first Android application and I must say at this stage, I rushed and glossed over a lot of things in order to have a working proof of concept - I certainly have a lot to learn in regards to the best pratices.

IzzySoft commented 2 months ago

I certainly have a lot to learn in regards to the best pratices.

Haven't we all? "Whoever ceases to be a student, has never been one in the first place." I learn new stuff every day in this context, e.g. when exploring how to make my repo more safe and secure, see e.g. here (which is a continuous process).

Looking forward to your next release then, and thanks for your swift action!

Oh, speaking about my repo: you might wish to take a look here. I gladly send you a PR with the metadata (currently only summary and description, plus the icon) in fastlane format – so you can be in control how your app is presented, and build on that; e.g. add some screenshots. You're welcome to use my Fastlane Cheat Sheet for orientation with that.

Mathieu-Beliveau / android-virtual-pen

versioning #1