search

Mathijs-Bakker / Extenject

Dependency Injection Framework for Unity Game Engine
MIT License
514 stars 96 forks source link

Readme should clarify relation to modesttree/zenject and what happened to svermeulen/extenject #4

Open johanhelsing opened 3 years ago

johanhelsing commented 3 years ago

It looks like this is an actively maintained fork? But it's pretty hard to tell at first glance (i.e. it looks sort-of like it was just used for pull requests to svermeulen/extenject.)

Mathijs-Bakker commented 3 years ago

Yes, you're totally right.

Currently I can confirm - and share with you - is:

I am going to update the readme at an appropriate time. So I will keep your issue open and hope to close this soon!

Thank you for caring!

Mathijs

STARasGAMES commented 3 years ago

There are a lot of confusions with several zenject and extenject versions. For example, Extenject github link on the Asset Store leads to modesttree/zenject. image

I just want to know which is the best option to use:)

Previously I can just type Extenjext on google and find appropriate repository to download. Now I can't. Unfortunately, I don't remember who was the maintainer, so I just lost in this situation.

If there are any(or no) differences between Zenject and Extenject, this could be pointed out at the start of the README, so it's easier to decide.

Cheers! ❤️

johanhelsing commented 3 years ago

I will definitely keep THIS fork updated. And contributions are ❤️ .

That's a relief to hear!

And thanks so much for maintaining this project and all your work in the past.

I use it in almost every game jam I do!

kkohno commented 3 years ago

I am use this too in each project, and hope, this project (Zenject or Extenject) will be alive.

brunocapdevila commented 3 years ago

Hey! we are using Zenject/Extenject in almost all of our Unity projects.

We have been following this legal dispute with attention and worry. I hope we can soon have a statement from part of Modestree...

Happy to hear that you will maintain this fork.

The one thing that I would improve in Zenject is the time it takes to inspect each scene after loading. I think we could create a tool that bakes the references to injectable components and zenject bindings into the scene context itself.

gngriffiths commented 2 years ago

Is this still the best version to use or should we switch to UniDi?

Mathijs-Bakker commented 2 years ago

UniDi is a refactor of Extenject 9.2.0. All commits from that time stamp haven't made it into UniDi yet. The UniDi 'core' Di container framework is behaving as it should... but it's not recommended to use it in production for now. So this repo is still the safest - or 'best' - to use.

apples commented 2 years ago

As a new user, it was pretty hard to track down this repo!

It would be nice if there was a big bold banner in the readme saying "THIS IS THE ONE".

Regardless, thank you for maintaining this 🙏 Shame to hear about all that legal stuff...

yacuzo commented 2 years ago

UniDi is a refactor of Extenject 9.2.0. All commits from that time stamp haven't made it into UniDi yet. The UniDi 'core' Di container framework is behaving as it should... but it's not recommended to use it in production for now. So this repo is still the safest - or 'best' - to use.

Refactor and new name will also fix the confusion around finding the right repo. Please let us know when you feel it is ready for production use :)

Luciolla commented 2 years ago

Found this repo only because it has a link from the asset store, A search in the git gives strange results. Only Zenject-Hero, updated in 2018, is visible, which causes it to be ignored and searched further. And on the official page of Zenject is still 9.2.0 version...

I hope all this confusion will end soon :)) We are waiting, and hope.