Mathijs-Bakker / Extenject

Dependency Injection Framework for Unity Game Engine
MIT License
531 stars 97 forks source link

Installing via upm/git spams warnings due to sample games' scripts #50

Closed johanhelsing closed 2 years ago

johanhelsing commented 2 years ago

Describe the bug

Whenever I open my project or recompilation of zenject is triggered, I several screens of warnings from extenject.

This makes it harder to spot real problems in my repo.

To Reproduce

Open a fresh unity project.

Add extenject as a upm git dependency:

Wait for import and watch 54 warnings appear in the console.

    "com.svermeulen.extenject": "https://github.com/Mathijs-Bakker/Extenject.git?path=/UnityProject/Assets/Plugins/Zenject",

These warnings re-appear on certain times when I develop without actually touching extenject. I'm not sure exactly why/when Unity sometimes decides to reimport extenject.

Expected behavior

A clean import with no warnings.

Screenshots

image

Extenject and Unity info (please complete the following information):

I made an attempt to fix this here: https://github.com/modesttree/Zenject/pull/220

It kind of stalled because maybe it broke asset store and or .unitypackage installation of samples and I didn't have the time to investigate and fix potential issues for a build system I was not going to use anyway.

However a lot has happened since then. The original svermeulen/extenject repo and its PRs was hijacked by modesttree after the lawsuit and then the zenject project was once again abandoned.

I'm not sure if all 4 installation options listed in the readme are still supported? It would certainly make fixing this issue a lot easier if we can drop the asset store path and focus on the upm distribution only.