search

Mathilde-16 / STOP_MS_data

0 stars 0 forks source link

Data processing progress : segmentation and vertebral labeling #4

Closed Mathilde-16 closed 3 months ago

Mathilde-16 commented 5 months ago

Could you tell me what do you think about this script please ? https://github.com/Mathilde-16/STOP_MS_data/blob/c5bbd51d612161c7ff6d42657821202002fc3d41/Dataprocessing/Segmentation%26_Vertebral-labeling_BIDS-data/Batch_script.sh

jcohenadad commented 5 months ago

Could you tell me what do you think about this script please ? c5bbd51

the link refers to a commit (with a LOT of changes), not a script. here is an example of a URL that points to a file at a specific commit SHA: https://github.com/Mathilde-16/STOP_MS_data/blob/c5bbd51d612161c7ff6d42657821202002fc3d41/Data_processing/Segmentation_%26_Vertebral-labeling_BIDS-data/OUTPUT/Terminal_Output_batch_script

Mathilde-16 commented 5 months ago

Thanks for the exemple, I've just edited my issues #4 and #5

jcohenadad commented 5 months ago

Could you tell me what do you think about this script please ? https://github.com/Mathilde-16/STOP_MS_data/blob/main/Dataprocessing/Segmentation%26_Vertebral-labeling_BIDS-data/Batch_script.sh

no, this is pointing to the main branch (which is not static and always evolves with new commit)-- the 'main' should be replaced with the commit SHA of the script you would like feedback on

Mathilde-16 commented 5 months ago

I've just edited issues #4 and #5 with the commit SHA

jcohenadad commented 5 months ago

this is the landing page for the URL you edited yesterday: image

please make sure to test the link before posting-- thank you

Mathilde-16 commented 5 months ago

The link below works well in my computer when I click on it or when I copy/paste it into a search engine. However, I don't know if it's going to work for you because when I copy/paste the link I wrote on the first message of this issue #4, it's work well too.

https://github.com/Mathilde-16/STOP_MS_data/blob/c5bbd51d612161c7ff6d42657821202002fc3d41/Data_processing/Segmentation_%26_Vertebral-labeling_BIDS-data/Batch_script.sh

Hoping it's going to work for you

jcohenadad commented 5 months ago

yes, working well now, but in the future it is a good idea to avoid non alphanumerical ASCII characters like "&" which are interpreted in URLs as "%26" and depending on the OS/browser could cause issues

jcohenadad commented 5 months ago

I've commented the code via recent issues #7 #8 #9 #10

Mathilde-16 commented 5 months ago

yes, working well now, but in the future it is a good idea to avoid non alphanumerical ASCII characters like "&" which are interpreted in URLs as "%26" and depending on the OS/browser could cause issues

Okay, my apologies for this confusion.

I've commented the code via recent issues https://github.com/Mathilde-16/STOP_MS_data/issues/7 https://github.com/Mathilde-16/STOP_MS_data/issues/8 https://github.com/Mathilde-16/STOP_MS_data/issues/9 https://github.com/Mathilde-16/STOP_MS_data/issues/10

Thank you for your help !

jcohenadad commented 3 months ago

will open a new issue in https://github.com/sct-pipeline/STOP-MS-data/issues to follow-up on recent processing results