search

Mathilde-16 / STOP_MS_data

0 stars 0 forks source link

Data processing progress : contrast-agnostic-segmentation and vertebral labeling #5

Closed Mathilde-16 closed 3 weeks ago

Mathilde-16 commented 1 month ago

Could you tell me what do you think about this script please ? https://github.com/Mathilde-16/STOP_MS_data/blob/c1a80edec06823005e9c3bd31b535f213eb1bded/Dataprocessing/ContrastAgnosticSeg%26_Vertebral-labeling_BIDS-data/Batch_script.sh

jcohenadad commented 1 month ago

same issue as https://github.com/Mathilde-16/STOP_MS_data/issues/4#issuecomment-2137849626

Mathilde-16 commented 1 month ago

https://github.com/Mathilde-16/STOP_MS_data/blob/8240dfd021f558435050e73553de778ab5b0737b/Data_processing/ContrastAgnosticSeg_%26_Vertebral-labeling_BIDS-data/Batch_script.sh

Does the link above works for you ?

jcohenadad commented 1 month ago

yes it does, but isn't this script a somewhat duplicate of this other script, on which i've already made comments? https://github.com/Mathilde-16/STOP_MS_data/issues/4#issuecomment-2142707197

This is all very confusing... I'm not sure what script is for what...

Mathilde-16 commented 4 weeks ago

My explanations correspond to this comment in issue #7

jcohenadad commented 3 weeks ago

I suggest to close this issue until the code duplication is solved-- then I will be able to give proper feedback on the codebase and methods comparison