MathisRosenhauer / libaec

libaec - Adaptive Entropy Coding library
https://gitlab.dkrz.de/k202009/libaec
BSD 2-Clause "Simplified" License
12 stars 9 forks source link

Bugfix/cmake #16

Closed jwsblokland closed 3 years ago

jwsblokland commented 3 years ago

Hello Mathis,

Here at Shell we make use of the HDF5 to store large files. A colleague of mine came across your libaec library and mentioned it a drop-in replacement of the Szip compression library in HDF5. To make this drop-in replacement more smooth, I made several improvements regarding the cmake files for building the libaec library:

With these changes in place, I could easily build HDF5 library from scratch with the option to include either the shared or static szip library provided by your libaec library. For the static version I needed to make a little modification the HDF5 CMakeFilters.cmake file which I upload to HDF group once this pull request has been approved.

Best regards, Jan-Willem

MathisRosenhauer commented 3 years ago

Hello Jan-Willem,

I'm not totally comfortable with just ignoring BUILD_SHARED_LIBS but I guess there is no better way. I will make a new release once your HDF5 changes are accepted.

Cheers, Mathis