search

Mathnerd314 / page-translator

One-click page translation for Firefox
ISC License
9 stars 4 forks source link

on Android missing save button #9

Closed ghost closed 3 years ago

ghost commented 4 years ago

Great add-on.

On Android Firefox when changing the settings for the add-on there is no button to save. The dropdown language selectors seem to automatically save themselves, but the checkboxes don't.

(tested on Samsung Galaxy Note 9 with Android 10 and Firefox 68.6.0)

Mathnerd314 commented 4 years ago

Automatic language detection doesn't work on Android, so I imagine you are simply seeing that "Always show page action" cannot be turned off.

ghost commented 4 years ago

Here's a screenshot of what I see:

20200315_203620

And a screenshot of another add-on that has a save button (to understand better what I mean):

20200315_203720

Mathnerd314 commented 4 years ago

Hmm. The save code autosaves with every option change and uses a single codepath that saves all the options at once. So I don't see how it would fail to save. I guess you could try uninstalling and reinstalling, it works fine here (Android 7).