Mathpix / mathpix-markdown-it

Markdown rendering + Latex extras (equations, tables, ...), with conversion features, for the scientific community
MIT License
465 stars 42 forks source link

PR into master from dev/olga/use-npm-domino #286

Closed OlgaRedozubova closed 7 months ago

OlgaRedozubova commented 7 months ago

branch: dev/olga/use-npm-domino

Why

A user reported a problem:

I am writing to bring to your attention an issue we are encountering with the Mathpix Git Code Library when attempting to download it for our Node.js Angular 16 project.

When we try to download the library, we are facing the following error:

npm ERR! An unknown git error occurred npm ERR! command git --no-replace-objects ls-remote ssh://git@github.com/Mathpix/domino.git npm ERR! git@github.com: Permission denied (publickey). npm ERR! fatal: Could not read from remote repository.

It seems that for this user this problem is related to ssh access https://docs.github.com/en/authentication/troubleshooting-ssh/error-permission-denied-publickey

What's being changed:

We published npm package @mathpix/domino so that access to the git repository is not required

Use "@mathpix/domino": "2.1.8" instead of a link to the git repository "domino": "https://github.com/Mathpix/domino.git"