Mathux / TEMOS

Official PyTorch implementation of the paper "TEMOS: Generating diverse human motions from textual descriptions", ECCV 2022 (Oral)
https://mathis.petrovich.fr/temos/
MIT License
366 stars 25 forks source link

something wrong in the paper #24

Closed eanson023 closed 9 months ago

eanson023 commented 1 year ago

In the code, the num_heads of the transformer encoder in config cannot be injected into the .py file because of a spelling error, so it is always 4, which is not equal to num_layer like the paper

eanson023 commented 1 year ago

And the latent_dim in the paper is set to 256. When num_head is 6, it cannot be divisible, so the multi-head attention mechanism will not take effect, and pytorch will report an error

Mathux commented 1 year ago

Hello eanson023,

Thanks for opening this issue, it is indeed a bug, I will fix it. I called the parameter "num_head" in the config instead of "num_heads".

I am currently reimplementing this code base, to make it better and more clear, and avoid those kind of issues.

Mathux commented 9 months ago

I made the new code base available in the TMR repo: http://github.com/Mathux/TMR

eanson023 commented 9 months ago

Thank you (you can still remember this thing lol😄)