Mathux / TEMOS

Official PyTorch implementation of the paper "TEMOS: Generating diverse human motions from textual descriptions", ECCV 2022 (Oral)
https://mathis.petrovich.fr/temos/
MIT License
366 stars 25 forks source link

About checkpoints #5

Closed dwro0121 closed 2 years ago

dwro0121 commented 2 years ago

Hi, thanks for your great work. I have a question about checkpoints.

I saw config files, and I can find that you used mode=max in latest_checkpoint.yaml, but I can't find it in last_checkpoint.yaml. so if you used the same metrics for them, I think we need to remove it from latest_checkpoint.yaml. (If use error or loss for metrics)

How do you think about this?

Additionally, I want to know which one is the best model. Is the last.ckpt the best model with metrics (valid error or loss)?

thanks.

Mathux commented 2 years ago

Hello @dwro0121,

To clarify:

Actually, about the config files, it does not matter so much: the default behaviour withmonitor: None is to save the last checkpoint. I will remove monitor: stepand mode: max from latest_checkpoint which do the same thing, it will be more clear. Thanks for pointing this out to me.

To simplify things, the best model is the last.ckpt, the checkpoint after a full training. I am not using the validation metric/loss to choose the best model.

dwro0121 commented 2 years ago

Questions have been resolved. Thank you for the reply.