SSD1306_DrawPixel parameter check.

[bpringlemeir]

https://github.com/Matiasus/SSD1306/blob/ce135fab47cd65dc58a2df5739a3c595ce4bb8b9/lib/ssd1306.c#L522

I think there is an issue with the parameter checking in this routine?

  if ((x > MAX_X) && (y > MAX_Y)) {
    // out of range
    return SSD1306_ERROR;
  }

It should be '||' as we need both parameters to be in range?

[Matiasus]

Hi Bill,

Yes, You're right, I'm going to change it. Thanks a lot.

Best regards Marián

st 14. 6. 2023 o 17:35 Bill Pringlemeir @.***> napísal(a):

https://github.com/Matiasus/SSD1306/blob/ce135fab47cd65dc58a2df5739a3c595ce4bb8b9/lib/ssd1306.c#L522

I think there is an issue with the parameter checking in this routine?

if ((x > MAX_X) && (y > MAX_Y)) { // out of range return SSD1306_ERROR; }

It should be '||' as we need both parameters to be in range?

— Reply to this email directly, view it on GitHub https://github.com/Matiasus/SSD1306/issues/10, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACZOSOEO6Q6K2LG4OT2PT23XLHK45ANCNFSM6AAAAAAZGRXJL4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[Matiasus]

Changed.