Is this essentially 'done' and ok to use in production?

edtjones commented 1 year ago

Hello there - I just wanted to check whether this loader and layer are essentially 'done' and usable in production? Or is it more of a proof-of-concept?

It looks pretty much done to me, but wanted to check!

Thanks 🙂

edtjones commented 1 year ago

and I guess @nofurtherinformation I should ask - what's involved in getting raster PMTiles to work, and how can I help?

(I am using this in production and it's great - thanks for your work)

nofurtherinformation commented 1 year ago

Hi there @edtjones and sorry for the slow reply here! Super glad to hear this has been useful!

I think it's pretty close to being feature-complete and with some sprucing up could be reasonably production-ready. The main things to do would be:

Raster Support

[ ] Check if the current raster data parser is actually working correctly
[ ] Provide a default BitMapLayer implementation as the default sublayer render, when using raster
[ ] Document raster vs vector settings, potentially split into two layer specs if too confusing
[ ] Check if Pmtiles head v3 provides raster vs vector info, in case unspecified

Caching

[ ] Slight refactor to better match core PMtiles library
[ ] Align cache strategies with Mapboxgl/Maplibre implementation

General dev ops

[ ] Implement backwards compatible reader (can be borrowed pretty closely from the core PMTiles library)
[ ] Test, better comments

Beyond those, there is some Typescript cleanup that could be good (I hadn't quite wrapped my mind around the way Deck uses generics on my first pass here) and some more docs

nofurtherinformation commented 1 year ago

I'd be thrilled if you'd want to start an issue and a PR on the raster stuff -- I've had the caching and general cleanup on my todo list for a while now and could tackle those In the near future!

edtjones commented 1 year ago

@nofurtherinformation sorry for the slow reply. We've got some stuff in the roadmap which will necessitate rasters so I'll have a play soon.

edtjones commented 1 year ago

@nofurtherinformation just to let you know (although I am quite sure you were not particularly waiting for a followup from me!) that because @bdon has released a Cloudflare workers script which converts z/x/y requests to PMTiles requests, I've bumped making rasters work down the list of priorities (because I can just issue z/x/y requests). See https://protomaps.com/docs/cdn/cloudflare if you're interested.

We do still use this lib in production for vectors though, so thankyou for all your work on this!

Matico-Platform / deck.gl-pmtiles