search

MatiseAms / generator-matise

Yeoman generator for matise projects
0 stars 0 forks source link

list-style-type: none; should not be the standard #46

Open Sidstumple opened 6 years ago

Sidstumple commented 6 years ago

The standard now is to not display list style types at all...

silvandiepen commented 6 years ago

disagree

silvandiepen commented 6 years ago

argumentation:

mmeester commented 6 years ago

I'm on team @Sidstumple

silvandiepen commented 6 years ago

I love horses.

Sidstumple commented 6 years ago

This is the same issue as deleting focus styles. It's apparently not realistic to expect developers to do this themselves, as this is a problem in a lot of our projects. Maybe we should put it in our test routine and leave the standard user agent styles for now?

Sidstumple commented 6 years ago

Content lists, need to be styled to work with the default style. Margins and paddings are Always designed different from basic lists.

BTW I do not think this is a very valid argument; why would you not display the style type if you want developers to adjust padding and margin?

silvandiepen commented 6 years ago

its about using the ul,li{ margin: 0; padding: 0; list-style-type: none; } as as reset.

There is unfortunately no such thing as a "standard user agent style". This because every browser has its own interpretation and thats why its added in the reset. To keep it everywhere the same and start styling from scratch.

Disabling focus styles is in my opinion another thing, I do agree we can remove this. Also as a reminder to change the focus styles based on the design. This is also a accessibility thing, which we should work on a lot more!

Sidstumple commented 6 years ago

Then set a standard list style type, do not make it invisible. The only place where you definitely do not want to display list types is in the navigation, the rest is very variable and unpredictable.

silvandiepen commented 6 years ago

95% of the time you (at least I) want to disable the styling of a list. Except for content. In this case content is an exception and could have a default styling.

I do prefer to disable the style type in general and accepting in for instance .content elements to have some sort of default styling, or browser defined list style types.