search

MatmaRex / patchdemo

This repository has been moved to GitLab: https://gitlab.wikimedia.org/repos/ci-tools/patchdemo
https://gitlab.wikimedia.org/repos/ci-tools/patchdemo
MIT License
25 stars 21 forks source link

Add some configuration needed for Kartographer #562

Closed WMDE-Fisch closed 1 year ago

WMDE-Fisch commented 1 year ago

I get the following error when trying to use patchdemo for Kartographer:

A dependency error was encountered while installing the extension "Kartographer": Could not find the registration file for the extension "JsonConfig";

I'm not very much into what's going on there, but in our dev env we use the lines I added here as a default for the Kartographer set.

MatmaRex commented 1 year ago

A dependency error was encountered while installing the extension "Kartographer": Could not find the registration file for the extension "JsonConfig";

This probably just means that, in the "Choose included repos" section, you selected "Kartographer" but unselected "JsonConfig". However, "Kartographer" depends on "JsonConfig" (in extension.json). Patchdemo actually doesn't check these dependencies, but perhaps it should.

I can merge the change anyway, if you want?

WMDE-Fisch commented 1 year ago

D'oh yeah seems like it. I thought I did it twice and looked out for that. But seems not. - No hard feelings about the patch then, I guess I'll close it. At least the reasoning is totally wrong. - Like I said, it was kind of a blind shot.

Thanks. Works great so far :-)