Matocolotoe / Skript-1.8

The Skript plugin made for Minecraft 1.8.x only. Releases will follow the original repository, except for some bug fixes. Please read the README before updating to Skript-1.8 !
https://discord.gg/yh3Z98m
GNU General Public License v3.0
47 stars 4 forks source link

Suggestion: Readd on inventory open for player's inventory #62

Closed c0dingnoobi closed 1 year ago

c0dingnoobi commented 1 year ago

Skript Version

Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
Skript's documentation can be found here: https://skriptlang.github.io/Skript
Server Version: git-Titanium-JENKINS-dev-83 (MC: 1.8.8)
Skript Version: 2.6.2
Installed Skript Addons: 
- skript-placeholders v1.5.2 (https://github.com/APickledWalrus/skript-placeholders)
- skript-gui v1.3-beta2 (https://github.com/APickledWalrus/skript-gui)
- skript-yaml v1.4
- skDragon v0.17
- skript-reflect v2.3 (https://github.com/TPGamesNL/skript-reflect)
 SkBee v1.10.2 (https://github.com/ShaneBeee/SkBee)
Installed dependencies: 
- Vault v1.7.3-b131
- WorldGuard v6.2.1;84bc322

Bug Description

Since Mojang replaced achievements with advancements in 1.12+ they also removed firing the InventoryOpenEvent for player's inventory. The server isn't sending a packet anymore which resulted in Skript removing it when opening player's inventory. (only gets called when opening containers/guis)

This shouldn't be the case for this 1.8 fork since the server is still sending a packet on 1.8 Servers. Adding this feature back to Skript would be useful.

Expected Behavior

Firing InventoryOpenEvent when opening player's inventory

Steps to Reproduce

Errors or Screenshots

No errors. Video shouldn't be needed for this.

Other

No response

Agreement

c0dingnoobi commented 1 year ago

mb misunderstood stuff