search

Matoking / protontricks

A wrapper that does winetricks things for Proton enabled games, requires Winetricks.
GNU General Public License v3.0
1.66k stars 36 forks source link

Fix metainfo warnings #127

Closed stephanlachnit closed 2 years ago

stephanlachnit commented 2 years ago

Debian reported several issues with the AppStream file: https://appstream.debian.org/sid/contrib/issues/protontricks.html

You can check them yourself by running appstreamcli validate --pedantic data/com.github.Matoking.protontricks.metainfo.xml. The output before this PR:

$ appstreamcli validate --pedantic ./com.github.Matoking.protontricks.metainfo.xml 
I: com.github.Matoking.protontricks:7: summary-has-dot-suffix
     Um invólucro simples que executa truques de winetricks para jogos habilitados para usar o
     Proton.
I: com.github.Matoking.protontricks:6: summary-has-dot-suffix
     A simple wrapper that does winetricks things for Proton enabled games.
P: com.github.Matoking.protontricks:3: cid-contains-uppercase-letter
     com.github.Matoking.protontricks
I: com.github.Matoking.protontricks:8: summary-has-dot-suffix
     Un contenedor simple que realiza trucos de winetricks para juegos habilitados para usar
     Proton.
I: com.github.Matoking.protontricks:17: description-first-para-too-short
     A simple wrapper that does winetricks things for Proton enabled games.
E: com.github.Matoking.protontricks:~: extends-not-allowed
W: com.github.Matoking.protontricks:~: console-app-no-binary

Validation failed: errors: 1, warnings: 1, infos: 4, pedantic: 1

After this PR:

$ appstreamcli validate --pedantic data/com.github.Matoking.protontricks.metainfo.xml 
P: com.github.Matoking.protontricks:3: cid-contains-uppercase-letter
     com.github.Matoking.protontricks

Validation was successful: pedantic: 1

I get why the extends tag is wanted, however this is not how it is defined in the spec. It is only for addons, which also must be denoted as type="addon". Better would be something like enhances, but this is not present in the spec. Instead I added Steam as recommends, which still shows Steam in the Store and does not break the spec. I also added and icon like in the desktop file and fixed other minor things.

Matoking commented 2 years ago

Thanks for the pull request. I've added a few comments, but looks good to me otherwise.

Assuming nothing else comes up, I'll probably push a small release later this week with these changes included.