search

Matoking / protontricks

A wrapper that does winetricks things for Proton enabled games, requires Winetricks.
GNU General Public License v3.0
1.61k stars 34 forks source link

Warn users if ( or danger of ) using older winetricks #197

Closed JJones780 closed 1 year ago

JJones780 commented 1 year ago

Older versions of winetricks will install older versions of DLLs !

A warning that an older version of winetricks will result in older DLLs would be welcome!

See https://github.com/ValveSoftware/Proton/issues/3106 as an example of where this warning might've helped.

Matoking commented 1 year ago

I looked into implementing this, but turns out Winetricks already has an automatic check for version updates. However, it's disabled under Debian and likely other derivatives:

    # In Debian we don't connect automatically to a remote site for privacy reasons.
    #winetricks_latest_version_check

The page for Winetricks also specifically points out Debian / Ubuntu as distros that usually ship outdated Winetricks versions and where manual install is preferred instead. As such, I don't think implementing a version check that mostly caters for one family of distros -- and is redundant on others -- would be worth the maintenance effort.

The easy option would be to recommend manual install or Flatpak instead for Debian / Ubuntu, but I fear the README is already getting a bit convoluted.

JJones780 commented 1 year ago

I can relate to your concern about maintainability and agree the information might be lost in the readme. Hopefully places like protondb can make people aware of the issue well enough.

OTOH, a simple check for winetricks version > x might avoid some protontricks bug reports as well as alleviating dll issues.

Matoking commented 1 year ago

I've updated the README with a similar note.

One future fix might be for Protontricks to handle its own Winetricks installation. The Flatpak version already ships a slightly modified version of Winetricks with a few minor quality-of-life improvements when used with Protontricks. That's an entirely different can of worms though, and it will require a few changes to Protontricks itself.