Matoking / protontricks

A wrapper that does winetricks things for Proton enabled games, requires Winetricks.
GNU General Public License v3.0
1.67k stars 36 forks source link

Protontricks fails to install vcrun2019 #76

Open Berinth opened 3 years ago

Berinth commented 3 years ago

Describe the bug I'm trying to install vcrun2019 as it is necessary for the Cyberpunk 2077 performance overhaul mod. https://github.com/yamashi/PerformanceOverhaulCyberpunk/blob/master/PROTON.md

To Reproduce protontricks 1091500 vcrun2019

Expected behavior Vcrun 2019 to be installed successfully

System (please complete the following information):

Additional context heres is the output of the command:

vcrun2019.txt

Matoking commented 3 years ago

Could you try running the command again with the -v flag (eg. protontricks -v 1091500 vcrun2019)?

This could also be related to #72 if your distro is too old. This is unlikely, but you can run the command ldd --version to check this: the reported version should be v2.28 or newer.

Finally, you can run the command protontricks -c 'wine --version' 1091500 and check if it prints the Wine version.

Malternative3772 commented 3 years ago

Hi, I have a very similar problem, when trying to apply vcrun2017 to DCS world. It opens the installer for visual c++, but when trying to install it, it just shows the error 0x80070643 and quits.

My System:

The command output: vcrun2017_command_line_output.txt And the log of the visual c++ installer: vcrun2017_installer_log.txt

Matoking commented 3 years ago

@Malternative3772 I was able to reproduce the issue, kind of. The system Wine is able to install vcrun2019 correctly. I was also able to install vcrun2019 for a Proton game once, until it started failing for any game I tried, regardless of whether Steam Runtime was enabled or not.

From the look of things the issue is with either Winetricks or Proton. I'll have to look into this a bit more, though.

Matoking commented 3 years ago

I tested this more, and I was able to install vcrun2019 fine on a newly created Wine prefix using Proton Experimental and the newest Winetricks version. vcrun2017 on the other hand didn't work on the newer Proton versions but worked fine using Proton 4.11.

It seems that in this case the behavior of newer Proton is different enough from vanilla Wine that Winetricks is unable to install this verb correctly. One workaround I've read from GitHub is circumventing Proton's own binaries entirely and installing the verb using system Wine (which you might need to install separately). You could do this like this:

# First, find the prefix path
$ protontricks -c "env | grep WINEPREFIX" <appid>
WINEPREFIX=<prefix_path>

# Now, use the prefix path to run Winetricks using system binaries
$ WINEPREFIX=<prefix_path> winetricks vcrun2017
platyple commented 3 years ago

so i tried both protontricks and directly going through my system's wine, i get the same error as @Malternative3772 just with vcrun2019. for reference, here's the installer logs for both ways vcrun2019log_winetricks.txt vcrun2019log_protontricks.txt

(sidenote, i had to manually update the checksum for the binary in winetricks because it was updated since the last release of winetricks)

ethanmad commented 3 years ago

I am also having issues installing vcrun2019, but at a different step (cabextract) than I have seen in the other logs shared. I had to run winetricks --self-update to get past the sha256sum error for vcrun2019.

System:

I wonder if the difference between protontrick's version of wine and system wine is causing issues. But I do get the same result when using @Matoking's suggestion of changing the wineprefix to use system binaries, so maybe not.

My log file is attached. Any ideas?

vcrun2019log_protontricks-git.txt

freddfx commented 3 years ago

I am also having issues installing vcrun2019, but at a different step (cabextract) than I have seen in the other logs shared. I had to run winetricks --self-update to get past the sha256sum error for vcrun2019.

System:

* Distro: Arch Linux

* Protontricks version: protontricks (1.5.3.dev1+gcd89dd1) (`protontricks-git` from AUR); also tried with `protontricks` from AUR and had the same result

* Steam version: 1.0.0.70-1

* wine version: wine-6.10

* winetricks version: 20210206-next - sha256sum: e08cfb38938b63f34f9b19d59791b79779fdb2c1f636599a54e81332eb3d511b

* `protontricks -c 'wine --version' 1091500`: wine-6.3

* `ldd --version`: ldd (GNU libc) 2.33

* proton experimental

I wonder if the difference between protontrick's version of wine and system wine is causing issues. But I do get the same result when using @Matoking's suggestion of changing the wineprefix to use system binaries, so maybe not.

My log file is attached. Any ideas?

vcrun2019log_protontricks-git.txt

That looks related to https://github.com/Winetricks/winetricks/issues/1736 Since Protontricks is just a wrapper for Winetricks that may resolve the issue.

karljohan122 commented 4 months ago

Still having this issue. Was there any solution found?

Soundtoxin commented 4 months ago

Still having this issue. Was there any solution found?

I've heard some people work around this by making a brand new wine prefix with Lutris and then copying game files to it afterward. I haven't tried this yet as I don't know Lutris well.

I ran into this same issue trying to get GTA V mods working. Both vcrun and dotnet stuff weren't installing properly.