MatrexsVigil / harvestcraft

All rights reserved - None of my artwork is available to be used for FREE in your game EVER. If you want to HIRE ME, please contact me. Thank you. This code is here for people to learn from and to help find bugs ONLY.
https://www.patreon.com/pamsmods
89 stars 85 forks source link

[1.12.2] Loot Tables #153

Open FoxBotGames opened 6 years ago

FoxBotGames commented 6 years ago

Vaygrim is making a modpack with Spice of life, Pam's Harvestcraft, and some dozen other mods.

As of the latest 1.12 HarvestCraft version the HarvestCraft Loot Tables have an interesting issue. The food from Harvestcraft appears in loot chests a normal rate however when they are inside a chest's loot table the entire chest gets filled with completely or to near full of ONLY Pam's Food. This so far has only appeared inside Buildings spawned in by the mod Lost Cities (image for example) it has only been run into through these buildings.

this

I can provide mod list if needed, modpack is in too early version to dump Curse link.

FoxBotGames commented 6 years ago

Does not only affect Lost Cities loot chests. Also Affects Vanilla loot chests

Goldenlion5648 commented 6 years ago

The harvestcraft foods appear in dungeon chests as the majority of the chest. I found that this is because the loot table files say "chance: 5.0" when this is supposed to be a decimal value. So in this instance (and all of the others, since all of the harvestcraft items in the loot tables have "chance: 5.0") it should be "chance: 0.05" (assuming it was intended to be 5%)

CovertJaguar commented 4 years ago

Can anyone point me at the file that needs to edited to fix this?

CovertJaguar commented 4 years ago

On closer inspection it appears to be a HungerOverhaul issue: https://github.com/progwml6/HungerOverhaul/issues/134

It can be disabled entirely in the HungerOverhaul config. It is not possible to properly fix via config file due to the loot value being an integer not a float.